-
Notifications
You must be signed in to change notification settings - Fork 1
Add purchase metadata #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch branch is based off the previous commit with Plutonomicon/cardano-transaction-lib@f5785cd applied The use of `/\` in an instance declaration was causing an invalid string literal in the output JS, something like "toMetadataArray/\"
First 2 points - yes |
Base automatically changed from
aleksandr/fd-to-nix-develop
to
neil/typescript-api
July 1, 2022 10:17
samuelWilliams99
approved these changes
Jul 5, 2022
…l/seabug-contracts into calum/purchase-metadata
This branch has the Plutonomicon/cardano-transaction-lib#696 commit merged into it + includes my change to fix the build
samuelWilliams99
approved these changes
Jul 11, 2022
…l/seabug-contracts into calum/purchase-metadata
Merged
#22 includes all the changes of this PR (this metadata was necessary for minting too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8
policyId
andmintPolicy
, unclear how these should be filledpolicyId
is supposed to have aMintingPolicyHash
for the collection nft currency symbol, not sure how to get that since we only have the currency symbolScriptHash
mintPolicy
is just an arbitrary version string, maybe it's okay to have it empty for nowownerPkh
(andownerPrice
) go in the metadata: the value for the input token or the output tokenContract.Value.CurrencySymbol
toCardano.Types.Value.CurrencySymbol
because of a discrepancy between the metadata and theNftCollection
types, maybe the metadata code can be converted to use theContract.Value.CurrencySymbol
(since I believe that is the "public api" and best practice)