-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ENH: adds annotation filtering to raw figures #13425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DerAndereJohannes
wants to merge
3
commits into
mne-tools:main
Choose a base branch
from
DerAndereJohannes:annotation_regex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added `annotation_regex` parameter to :func:`mne.viz.raw.plot_raw`, automatically hiding annotations not matching the regex, by :newcontrib: `Johannes Herforth`_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -37,6 +37,8 @@ def plot_raw( | |||||||
color=None, | ||||||||
bad_color="lightgray", | ||||||||
event_color="cyan", | ||||||||
*, | ||||||||
annotation_regex=".*", | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you're going to add it here (which is reasonable) we need to make everything kwarg-only (which we've been doing to functions bit-by-bit)
Suggested change
|
||||||||
scalings=None, | ||||||||
remove_dc=True, | ||||||||
order=None, | ||||||||
|
@@ -61,7 +63,6 @@ def plot_raw( | |||||||
precompute=None, | ||||||||
use_opengl=None, | ||||||||
picks=None, | ||||||||
*, | ||||||||
theme=None, | ||||||||
overview_mode=None, | ||||||||
splash=True, | ||||||||
|
@@ -99,6 +100,9 @@ def plot_raw( | |||||||
Color to make bad channels. | ||||||||
%(event_color)s | ||||||||
Defaults to ``'cyan'``. | ||||||||
annotation_regex : str | ||||||||
A regex pattern applied to each annotation's label. | ||||||||
Matching labels remain visible, non-matching labels are hidden. | ||||||||
%(scalings)s | ||||||||
remove_dc : bool | ||||||||
If True remove DC component when plotting data. | ||||||||
|
@@ -373,6 +377,7 @@ def plot_raw( | |||||||
event_times=event_times, | ||||||||
event_nums=event_nums, | ||||||||
event_id_rev=event_id_rev, | ||||||||
annotation_regex=annotation_regex, | ||||||||
# preprocessing | ||||||||
projs=projs, | ||||||||
projs_on=projs_on, | ||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.