Skip to content

Add type MoEInAppClickData for better type inference #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add type MoEInAppClickData for better type inference #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ import { MoEngageNudgePosition } from "../src/models/MoEngageNudgePosition";
import MoEAnalyticsConfig from "../src/models/MoEAnalyticsConfig";
import { MoESupportedAttributes } from "./models/MoESupportedAttributes";
import * as MoECoreHandler from "./utils/MoECoreHandler";
import MoEInAppClickData from "./models/MoEInAppClickData";

const PLATFORM_IOS = "ios";
const PLATFORM_ANDROID = "android";
Expand Down Expand Up @@ -137,7 +138,7 @@ type NotificationEventTypeMap = {
"pushTokenGenerated": MoEPushToken,
"pushClicked": MoEPushPayload,
"inAppCampaignShown": MoEInAppData,
"inAppCampaignClicked": MoEInAppData,
"inAppCampaignClicked": MoEInAppClickData,
"inAppCampaignDismissed": MoEInAppData,
"inAppCampaignCustomAction": MoEInAppData,
"inAppCampaignSelfHandled": MoESelfHandledCampaignData
Expand Down Expand Up @@ -755,6 +756,7 @@ var ReactMoE = {
export {
MoEInAppCustomAction,
MoEInAppNavigation,
MoEInAppClickData,
MoESelfHandledCampaignData,
MoEGeoLocation,
MoEProperties,
Expand Down
19 changes: 19 additions & 0 deletions sdk/core/src/models/MoEInAppClickData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import MoEAccountMeta from "./MoEAccountMeta";
import MoECampaignData from "./MoECampaignData";
import MoEInAppNavigation from "./MoEInAppNavigation";
import { MoEPlatform } from "./MoEPlatform";

export default class MoEInAppClickData {
accountMeta: MoEAccountMeta;
platform: MoEPlatform;
campaignData: MoECampaignData;
action: MoEInAppNavigation;

constructor(accountMeta: MoEAccountMeta, platform: MoEPlatform, campaignData: MoECampaignData, action: MoEInAppNavigation) {
this.accountMeta = accountMeta;
this.platform = platform;
this.campaignData = campaignData;
this.action = action;
}

}
3 changes: 2 additions & 1 deletion sdk/core/src/moeParser/MoEInAppParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import MoEngageLogger from "../logger/MoEngageLogger";
import MoECampaignContext from "../models/MoECampaignContext";
import MoECampaignData from "../models/MoECampaignData";
import MoEClickData from "../models/MoEClickData";
import MoEInAppClickData from "../models/MoEInAppClickData";
import MoEInAppCustomAction from "../models/MoEInAppCustomAction";
import MoEInAppData from "../models/MoEInAppData";
import MoEInAppNavigation from "../models/MoEInAppNavigation";
Expand Down Expand Up @@ -222,7 +223,7 @@ export function getNavigationObj(json: { [k: string]: any }, accountMetaPayload:
var platform = json[MOE_PLATFORM];
var accountMeta = getMoEAccountMeta(accountMetaPayload);
var action = getMoEInAppNavigation(json);
return new MoEClickData(accountMeta, platform, campaignData, action);
return new MoEInAppClickData(accountMeta, platform, campaignData, action);
}
else return undefined
}
Expand Down