Replace const enum with enum in MoEngageLogLevel for compatibility #65
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed MoEngageLogLevel from const enum to enum in sdk/core/src/models/MoEngageLogLevel.ts. This improves compatibility for consumers of the SDK by avoiding issues with TypeScript compilation and toolchain support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed MoEngageLogLevel from const enum to enum in sdk/core/src/models/MoEngageLogLevel.ts. This improves compatibility for consumers of the SDK by avoiding issues with TypeScript compilation and toolchain support.
Jira Ticket
N/A
Description
Description: This PR changes the definition of MoEngageLogLevel in sdk/core/src/models/MoEngageLogLevel.ts from const enum to enum.
Reason:
Using const enum can cause compatibility issues in SDKs or libraries consumed by external TypeScript or JavaScript projects, as it requires specific TypeScript compilation settings and isn’t supported by all toolchains. Switching to a regular enum ensures broader compatibility for all consumers.
Changes:
Replaced const enum MoEngageLogLevel with enum MoEngageLogLevel.
No functional changes; this is a compatibility and interoperability improvement.