react-native-expo-moengage - Adds moengage targets to the eas build appExtensions #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshiya-moengage
requested review from
abhishek-engg-mobilesdk and
msoumya-engg-sdk
wildseansy
force-pushed
the
sean/eas-managed-build-extras
branch
from
0055751 to
807def0
Compare
…AS to generate provisioning profiles for these targets
wildseansy
force-pushed
the
sean/eas-managed-build-extras
branch
from
807def0 to
6667f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAS CLI is smart enough to use the default Apple target for codesigning, but any additional targets need to be configured manually. Since
react-native-expo-moengageadds up to 3 more targets, EAS build needs to know about them to automate codesigning. In the docs, devs are expected to do this manually, but it can be also done automatically in the plugin.This PR adds automatic support for app extensions with respect to EAS build (the most common way that Expo apps are built)