Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure all issue in JS version
When we start implementing a quantum circuit, the
measure_all
function is intended to handle the measurements regardless whetherclbits
were defined previously.However, the old implementation was relying in this value being set by the user, and in the
measure_all
method, it was being check if the value innum_clbits
was0
, which was impossible, since it's value isundefined
by default.Update
Now, a default value
0
is defined form
, ensuring that even when no argument was inserted forclbits
, the value is valid.Tests
I also added some tests, that can be run using
node v22.18.0
.npm run test