Add additional filters to scanner query rules/results #23984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
force-pushed
the
scanners-query-results-more-filters
branch
from
0b71034 to
930bf98
Compare
eviljeff
approved these changes
Oct 6, 2025
| """ | ||
|
|
||
| template = 'admin/amo/numeric_range_filter.html' | ||
|
|
There was a problem hiding this comment.
When testing the label tags were empty (the label tag existed, but there was no text value). Date range filter fields get "To" and "From" labels; numeric range filter fields did not - though the placeholder texts did say "To" and "From".
Do you need to override _get_form_fields too?
At that point, you probably want to inherit from DateRangeFilter, or a common ancestor - it's worth considering anyway as your choices seems to be a direct copy and paste.
| choices=STATUS_CHOICES.items(), default=amo.STATUS_AWAITING_REVIEW | ||
| ) | ||
| datestatuschanged = models.DateTimeField(null=True, auto_now_add=True) | ||
| datestatuschanged = models.DateTimeField(null=True, default=timezone.now) |
There was a problem hiding this comment.
Not saying this is a bad change to make ... but we could just special case datestatuschanged field in file_factory - pop the value and set it after the create, and so avoid any database/model change to prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15831
Context
All fairly straightforward - just a couple annoyances:
FieldListFilterwill get theirtitleattribute set in__init__, hence the need for the custom__init__method in the new classes - we already did that for existing filtersrangefilterbrings, so we need a custom template & fake choices, exactly like we already do for the date one (seeamo.admin.DateRangeFilter)Addon.last_updatedis set automatically inaddon_factory(), using the normal code to compute it, which depends onFile.datestatuschanged. That field hadauto_now_addso it couldn't be set by the factory, I had to change it todefault=timezone.nowto allow that.