[DENG-10167] Speed up DAG generation #8477
Merged
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
scholtzan
changed the title
scholtzan
commented
Nov 19, 2025
| --ignore derived_view_schemas \ | ||
| --output-dir /tmp/workspace/generated-sql/sql/ \ | ||
| --target-project moz-fx-data-shared-prod | ||
| PATH="venv/bin:$PATH" script/bqetl format /tmp/workspace/generated-sql/sql/ |
Collaborator
Author
There was a problem hiding this comment.
We don't need to run the formatting if we use the existing generated-sql branch since anything on there is already properly formatted. The formatting does take 2-3 minutes to run
Contributor
There was a problem hiding this comment.
IIRC a lot (most?) of that is due to qualifying table references. That could be another thing to optimize but it seems hard to do
This comment has been minimized.
This comment has been minimized.
scholtzan
force-pushed
the
cache-stable-schemas
branch
from
cc1b347 to
99d0511
Compare
Integration report for "Use cached stable schemas for stage deploys"
|
kwindau
approved these changes
Nov 19, 2025
BenWu
approved these changes
Nov 19, 2025
| --ignore derived_view_schemas \ | ||
| --output-dir /tmp/workspace/generated-sql/sql/ \ | ||
| --target-project moz-fx-data-shared-prod | ||
| PATH="venv/bin:$PATH" script/bqetl format /tmp/workspace/generated-sql/sql/ |
Contributor
There was a problem hiding this comment.
IIRC a lot (most?) of that is due to qualifying table references. That could be another thing to optimize but it seems hard to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR speeds up the DAG generation process by:
generate-sqlstep and reuses them during DAG generation (save around 1.5minutes). If thegenerate-sqlstep gets skipped then it will still download schemasRelated Tickets & Documents
Reviewer, please follow this checklist