Skip to content

Conversation

@dleetr
Copy link

@dleetr dleetr commented Jun 3, 2023

This continues the PR from #2321 and resolves the original issues in #1979

Additionally, I have expanded the special handler cases to handle urls in the format chrome-extension://.

@dleetr
Copy link
Author

dleetr commented Sep 26, 2023

@Rob--W or @willdurand would either of you have some time to review this?

@nishu-murmu
Copy link

@Rob--W can anyone review and merge this PR?
We extensively require this feature.

@Rob--W
Copy link
Member

Rob--W commented Nov 14, 2024

I've added it to my to do list. Thanks for the ping.

@Rob--W
Copy link
Member

Rob--W commented Nov 8, 2025

@dleetr The latest version of this patch is very sparse. The original PR relied on the extension helper to open tabs. That reload helper was removed in favor of using the Chrome DevTools Protocol (CDP) as part of #3388.

The PR in its current form is not doing anything any more.

If you are interested in exploring the introduction of the feature with the CDP, see the CDP documentation at https://chromedevtools.github.io/devtools-protocol/

The PR that introduced CDP support is #3434. I suggest looking at individual commits instead of the whole diff if you want a better understanding of how the current code morphed from the original version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants