-
Notifications
You must be signed in to change notification settings - Fork 0
feat(root): use tsdown instead of tsup #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: eval-pr-2453-target-1758205412797
Are you sure you want to change the base?
Changes from all commits
cb3e9d1
dafc1ff
f20b9e1
78eca86
12b4bce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,8 @@ | |
"dist/**" | ||
], | ||
"scripts": { | ||
"build": "tsup-node src/index.tsx --format esm --target node20", | ||
"dev": "tsup-node src/index.tsx --format esm --target node20 --watch", | ||
"build": "tsdown src/index.tsx --format esm --target node20", | ||
"dev": "tsdown src/index.tsx --format esm --target node20 --watch", | ||
"clean": "rm -rf dist" | ||
}, | ||
"dependencies": { | ||
|
@@ -20,7 +20,7 @@ | |
"react-dom": "^19" | ||
}, | ||
"devDependencies": { | ||
"tsup": "^8.0.0", | ||
"tsdown": "^0.15.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The build migration from Prompt for AI agents
[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent |
||
"typescript": "^4" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,8 @@ | |
"dist/**" | ||
], | ||
"scripts": { | ||
"build": "tsup-node src/index.tsx --format esm --target node20", | ||
"dev": "tsup-node src/index.tsx --format esm --target node20 --watch", | ||
"build": "tsdown src/index.tsx --format esm --target node20", | ||
"dev": "tsdown src/index.tsx --format esm --target node20 --watch", | ||
"clean": "rm -rf dist" | ||
}, | ||
"dependencies": { | ||
|
@@ -20,7 +20,7 @@ | |
"react-dom": "^19" | ||
}, | ||
"devDependencies": { | ||
"tsup": "^8.0.0", | ||
"tsdown": "^0.15.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding tsdown ^0.15.1 while keeping TypeScript at ^4 creates a peer version mismatch (tsdown resolves against TypeScript 5.x). Align TypeScript to v5 to avoid tooling inconsistencies.
Reasoning: • Libraries consulted: tsdown, Tsdown Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent |
||
"typescript": "^4" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,8 @@ | |
"dist/**" | ||
], | ||
"scripts": { | ||
"build": "tsup-node src/index.tsx --format esm --target node20", | ||
"dev": "tsup-node src/index.tsx --format esm --target node20 --watch", | ||
"build": "tsdown src/index.tsx --format esm --target node20", | ||
"dev": "tsdown src/index.tsx --format esm --target node20 --watch", | ||
"clean": "rm -rf dist" | ||
}, | ||
"dependencies": { | ||
|
@@ -20,7 +20,7 @@ | |
"react-dom": "^19" | ||
}, | ||
"devDependencies": { | ||
"tsup": "^8.0.0", | ||
"tsdown": "^0.15.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two-agent-filter: Avoid using a caret range for pre-1.0 packages; minor updates can be breaking. Prefer ~0.15.1 or an exact version to prevent unexpected breakages.
Reasoning: • Libraries consulted: npm semver caret pre-1.0 behavior, node-semver caret ranges npm, Npmjs Prompt for AI agents
[internal] Confidence score: 7/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. single-agent-filter: Avoid using a caret range for pre-1.0 packages; minor updates can be breaking. Prefer ~0.15.1 or an exact version to prevent unexpected breakages.
Reasoning: • Libraries consulted: npm semver caret ranges 0.x behavior, node-semver caret range behavior ^0.x npm, Compare-versions, semver specification caret ranges pre-1.0 Prompt for AI agents
[internal] Confidence score: 7/10 [internal] Posted by: General AI Review Agent |
||
"typescript": "^4" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -22,7 +22,7 @@ | |||||||||||||
"happy-dom": "18.0.1", | ||||||||||||||
"pkg-pr-new": "0.0.54", | ||||||||||||||
"tsconfig": "workspace:*", | ||||||||||||||
"tsup": "8.4.0", | ||||||||||||||
"tsdown": "^0.15.1", | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use an exact version to align with the repo’s pinned devDependencies; a caret range can cause non-deterministic upgrades that may break builds. Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use an exact version instead of a caret range to align with pinned devDependencies and avoid unexpected bumps during 'pnpm install --no-frozen-lockfile'. Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use an exact version for tsdown to align with repository pinning and ensure reproducible builds.
Reasoning: Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two-agent-filter: Use a pinned version for tsdown to align with devDependencies conventions and ensure reproducible builds.
Reasoning: Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. single-agent-filter: Use a pinned version for tsdown to align with devDependencies conventions and ensure reproducible builds.
Reasoning: Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use a pinned version instead of a caret range to stay consistent with other devDependencies and ensure reproducible builds.
Reasoning: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid caret range for a pre-1.0 build tool; pin exact version to prevent unexpected breakages and keep dependency style consistent with other devDependencies. Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this violation is true There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use an exact version (no caret) for tsdown to match the pinned devDependencies and ensure reproducible builds.
Reasoning: Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent |
||||||||||||||
"tsx": "4.20.3", | ||||||||||||||
"turbo": "2.5.4", | ||||||||||||||
"vite": "7.0.4", | ||||||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -23,8 +23,8 @@ | |||||||||
}, | ||||||||||
"license": "MIT", | ||||||||||
"scripts": { | ||||||||||
"build": "tsup src/index.ts --format esm,cjs --dts --external react", | ||||||||||
"build:watch": "tsup src/index.ts --format esm,cjs --dts --external react --watch", | ||||||||||
"build": "tsdown src/index.ts --format esm,cjs --dts --external react", | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only "react" is externalized; include "react/jsx-runtime" (and dev variant) to avoid bundling JSX runtime with the library. Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The build script uses an incorrect, comma-separated value for the Prompt for AI agents
[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent
Suggested change
|
||||||||||
"build:watch": "tsdown src/index.ts --format esm,cjs --dts --external react --watch", | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only "react" is externalized; include "react/jsx-runtime" (and dev variant) to avoid bundling JSX runtime with the library.
Reasoning: • Libraries consulted: tsdown external option, Tsdown, React jsx-runtime automatic runtime imports react/jsx-runtime jsx-dev-runtime, React.dev Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent
Suggested change
|
||||||||||
"clean": "rm -rf dist", | ||||||||||
"test": "vitest run", | ||||||||||
"test:watch": "vitest" | ||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ | |
}, | ||
"license": "MIT", | ||
"scripts": { | ||
"build": "tsup src/index.ts --format esm,cjs --dts --external react", | ||
"build:watch": "tsup src/index.ts --format esm,cjs --dts --external react --watch", | ||
"build": "tsdown src/index.ts --format esm,cjs --dts --external react", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only 'react' is marked external; consider also externalizing 'react/jsx-runtime' to avoid bundling the JSX runtime when using the automatic JSX transform.
Reasoning: • Libraries consulted: React JSX runtime react-jsx automatic runtime, Vite-plugin-react, react/jsx-runtime automatic runtime Prompt for AI agents
[internal] Confidence score: 7/10 [internal] Posted by: General AI Review Agent |
||
"build:watch": "tsdown src/index.ts --format esm,cjs --dts --external react --watch", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only 'react' is marked external; consider also externalizing 'react/jsx-runtime' to avoid bundling the JSX runtime when using the automatic JSX transform.
Reasoning: • Libraries consulted: React JSX runtime react-jsx automatic runtime, Vite-plugin-react, react/jsx-runtime automatic runtime Prompt for AI agents
[internal] Confidence score: 7/10 [internal] Posted by: General AI Review Agent |
||
"clean": "rm -rf dist", | ||
"test": "vitest run", | ||
"test:watch": "vitest" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ | |
}, | ||
"license": "MIT", | ||
"scripts": { | ||
"build": "tsup src/index.ts --format esm,cjs --dts --external react", | ||
"build:watch": "tsup src/index.ts --format esm,cjs --dts --external react --watch", | ||
"build": "tsdown src/index.ts --format esm,cjs --dts --external react", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Externalize 'react/jsx-runtime' along with 'react' so the JSX runtime isn't bundled; this library uses the automatic React JSX runtime per tsconfig.
Reasoning: • Libraries consulted: TypeScript JSX react-jsx runtime import react/jsx-runtime, microsoft typescript jsx react-jsx documentation, Typescript Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two-agent-filter: Build script uses tsdown, which requires Node >=20.19.0 per lockfile, but this package declares engines node >=18. This mismatch can cause build failures under Node 18. • Libraries consulted: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. single-agent-filter: Build script uses tsdown, which requires Node >=20.19.0 per lockfile, but this package declares engines node >=18. This mismatch can cause build failures under Node 18. • Libraries consulted: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent |
||
"build:watch": "tsdown src/index.ts --format esm,cjs --dts --external react --watch", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two-agent-filter: Watch script uses tsdown, which requires Node >=20.19.0 per lockfile, but this package declares engines node >=18. This mismatch risks failures when running watch on Node 18.
Reasoning: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. single-agent-filter: Watch script uses tsdown, which requires Node >=20.19.0 per lockfile, but this package declares engines node >=18. This mismatch risks failures when running watch on Node 18.
Reasoning: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent |
||
"clean": "rm -rf dist", | ||
"test": "vitest run", | ||
"test:watch": "vitest" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ | |
}, | ||
"license": "MIT", | ||
"scripts": { | ||
"build": "tsup src/index.ts --format esm,cjs --dts --external react", | ||
"build:watch": "tsup src/index.ts --format esm,cjs --dts --external react --watch", | ||
"build": "tsdown src/index.ts --format esm,cjs --dts --external react", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Build scripts reference the tsdown CLI, but the repository shows no tsdown dependency or usage; running these scripts is likely to fail without adding tsdown to the workspace. Prompt for AI agents
[internal] Confidence score: 7/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hallucination |
||
"build:watch": "tsdown src/index.ts --format esm,cjs --dts --external react --watch", | ||
"clean": "rm -rf dist", | ||
"test": "vitest run", | ||
"test:watch": "vitest" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,8 @@ | |
}, | ||
"type": "module", | ||
"scripts": { | ||
"build": "tsup-node", | ||
"build:watch": "tsup-node --watch src", | ||
"build": "tsdown", | ||
"build:watch": "tsdown --watch src", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specifying 'src' in the watch script may override the configured entry in tsdown.config.ts, leading to inconsistent build/watch behavior. Prefer relying on the config when watching. DEV MODE: This violation would have been filtered out by screening filters. Failing filters: uncertaintyLanguage.
Reasoning: • Libraries consulted: tsdown CLI entry overrides config, Tsdown Prompt for AI agents
[internal] Confidence score: 7/10 [internal] Posted by: General AI Review Agent
sanxroz marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Reasoning: • Libraries consulted: tsdown CLI watch entry arguments, Tsdown Prompt for AI agents
[internal] Confidence score: 6/10 [internal] Posted by: General AI Review Agent |
||
"clean": "rm -rf dist", | ||
"test": "vitest run", | ||
"test:watch": "vitest" | ||
|
@@ -53,7 +53,7 @@ | |
"next": "^15.3.2", | ||
"react": "19.0.0", | ||
"react-dom": "19.0.0", | ||
"tsup": "8.4.0", | ||
"tsdown": "^0.15.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [email protected] requires Node >=20.19.0, but this package still advertises Node >=18.0.0. Developers using the supported Node 18 runtime will hit a build failure as soon as the new dev dependency runs. Please align the Node engine target or avoid upgrading to tsdown until it supports Node 18. Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent |
||
"typescript": "5.8.3" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { defineConfig } from 'tsup'; | ||
import { defineConfig } from 'tsdown'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The build configuration for the Prompt for AI agents
[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The build configuration for DEV MODE: This violation would have been filtered out by screening filters. Failing filters: typescriptUnderstanding.
Reasoning: Prompt for AI agents
[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Prompt for AI agents
[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent |
||
|
||
export default defineConfig({ | ||
dts: false, | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -95,8 +95,8 @@ | |||||
}, | ||||||
"license": "MIT", | ||||||
"scripts": { | ||||||
"build": "tsup-node", | ||||||
"build:watch": "tsup-node --watch", | ||||||
"build": "tsdown", | ||||||
"build:watch": "tsdown --watch", | ||||||
"clean": "rm -rf dist", | ||||||
"test": "vitest run", | ||||||
"test:watch": "vitest" | ||||||
|
@@ -130,7 +130,7 @@ | |||||
"@types/react-dom": "npm:[email protected]", | ||||||
"jsdom": "26.1.0", | ||||||
"tsconfig": "workspace:*", | ||||||
"tsup": "8.4.0", | ||||||
"tsdown": "^0.15.1", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use a pinned devDependency version for tsdown to match existing pinning and avoid unexpected build changes.
Reasoning: Prompt for AI agents
[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two-agent-filter: [email protected] requires Node >=20.19.0, but this package declares engines.node >=18. Adding this devDependency can cause install/build failures on Node 18. Align the engines.node to >=20 or use a tsdown version compatible with Node 18. • Libraries consulted: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. single-agent-filter: [email protected] requires Node >=20.19.0, but this package declares engines.node >=18. Adding this devDependency can cause install/build failures on Node 18. Align the engines.node to >=20 or use a tsdown version compatible with Node 18.
Reasoning: Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent |
||||||
"typescript": "5.8.3" | ||||||
}, | ||||||
"publishConfig": { | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { defineConfig } from 'tsup'; | ||
import { defineConfig } from 'tsdown'; | ||
|
||
export default defineConfig([ | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ | |
}, | ||
"license": "MIT", | ||
"scripts": { | ||
"build": "tsup src/index.ts --format esm,cjs --dts --external react", | ||
"build:watch": "tsup src/index.ts --format esm,cjs --dts --external react --watch", | ||
"build": "tsdown src/index.ts --format esm,cjs --dts --external react", | ||
"build:watch": "tsdown src/index.ts --format esm,cjs --dts --external react --watch", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tsdown requires Node >=20.19.0; using it here can break builds under Node 18 environments. Align the Node version used for builds or update the package engines to Node >=20.19.0.
Reasoning: • Libraries consulted: tsdown node engines requirement, Tsdown Prompt for AI agents
[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent |
||
"clean": "rm -rf dist", | ||
"test": "vitest run", | ||
"test:watch": "vitest" | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration from
tsup
totsdown
is incomplete. Thepackages/link/package.json
file was missed and its build scripts still usetsup
. Removing thetsup
dependency from the rootpackage.json
will break the build for the@react-email/link
package.Prompt for AI agents
[internal] Confidence score: 10/10
[internal] Posted by: System Design Agent