Skip to content

Fix ArgumentParser not handling noexcept in GCC 13.1 upwards #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix ArgumentParser not handling noexcept in GCC 13.1 upwards #4389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Shared/mods/deathmatch/logic/lua/CLuaFunctionParser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ struct CLuaFunctionParser
{
};

template <bool ErrorOnFailure, auto ReturnOnFailure, typename Ret, typename... Args, auto (*Func)(Args...)->Ret>
template <bool ErrorOnFailure, auto ReturnOnFailure, bool NoExcept, typename Ret, typename... Args, Ret (*Func)(Args...) noexcept(NoExcept)>
struct CLuaFunctionParser<ErrorOnFailure, ReturnOnFailure, Func> : CLuaFunctionParserBase
{
template <typename... Params>
Expand Down Expand Up @@ -832,7 +832,7 @@ struct CLuaFunctionParser<ErrorOnFailure, ReturnOnFailure, Func> : CLuaFunctionP
// Case where F is a class method pointer
// Note: If you see weird compiler errors like: Undefined type, overload resolution failed, etc..
// Ask on Dev Discord(#new-argument-parser), because rn this implementation is pretty beta. - 03/2021
template <bool ErrorOnFailure, auto ReturnOnFailure, typename T, typename R, typename... Args, R(T::*F)(Args...)>
template <bool ErrorOnFailure, auto ReturnOnFailure, typename T, bool NoExcept, typename R, typename... Args, R(T::*F)(Args...) noexcept(NoExcept)>
struct CLuaFunctionParser<ErrorOnFailure, ReturnOnFailure, F>
{
// Remove constness here, because we must be able to std::move
Expand Down
Loading