Skip to content

Limit non-added event logging (#4466) #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Limit non-added event logging (#4466) #4467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40d882
Limit un-added event logging (#4466)
ArranTuna Sep 15, 2025
eb2939c
Merge branch 'master' into client-event-error-limit
Dutchman101 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Server/mods/deathmatch/logic/CGame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
#define DEFAULT_AIRCRAFT_MAXHEIGHT 800
#define DEFAULT_AIRCRAFT_MAXVELOCITY 1.5f
#define DEFAULT_MINUTE_DURATION 1000
#define NUM_CLIENT_EVENT_ERROR_GAP 1000

#ifndef WIN32
#include <limits.h>
Expand Down Expand Up @@ -2673,15 +2674,22 @@ void CGame::Packet_LuaEvent(CLuaEventPacket& Packet)
}

}
else
else
{
// Limit this error to prevent debug / log files being flooded.
static std::uint64_t s_lastClientEventErrorLog = 0;
auto now = GetTickCount64_();
if (now - s_lastClientEventErrorLog > NUM_CLIENT_EVENT_ERROR_GAP)
{
CLuaArguments arguments;
arguments.PushString(szName);
arguments.PushBoolean(false);
arguments.PushBoolean(false);
pCaller->CallEvent("onPlayerTriggerInvalidEvent", arguments);
m_pScriptDebugging->LogError(NULL, "Client (%s) triggered serverside event %s, but event is not added serverside", pCaller->GetNick(), szName);
s_lastClientEventErrorLog = now;
}
}

RegisterClientTriggeredEventUsage(pCaller, szName);
}
Expand Down
Loading