proxy: properly handle getting an io.EOF from server->client forwards #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, I was able to observe a hang in the proxy in the specific scenario of: Bidirectional Client -> proxy -> proxy -> Bidirection Server This change seems to fix this hang that we've seen in practice, though I don't have any sort of self-contained test to reproduce the hang unfortunately. I suspect there's an easier reproduction with half-open streams (i.e. using `CloseSend`), though I haven't tried to make one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, I was able to observe a hang in the proxy in the specific scenario of:
Bidirectional Client -> proxy -> proxy -> Bidirection Server
This change seems to fix this hang that we've seen in practice, though I don't have any sort of self-contained test to reproduce the hang unfortunately.
I suspect there's an easier reproduction with half-open streams (i.e. using
CloseSend), though I haven't tried to make one.