Skip to content

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Sep 11, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou changed the title requestorderbook Add support for OrderBookDepth10 requests with databento Sep 11, 2025
@faysou faysou marked this pull request as draft September 11, 2025 21:31
@faysou faysou force-pushed the requestorderbook branch 2 times, most recently from b03dd51 to 44d1f27 Compare September 18, 2025 17:13
@faysou faysou marked this pull request as ready for review September 20, 2025 01:01
@cjdsellers
Copy link
Member

Thanks @faysou

@cjdsellers cjdsellers merged commit 4afc88b into develop Sep 21, 2025
32 of 33 checks passed
@cjdsellers cjdsellers deleted the requestorderbook branch September 21, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants