-
Notifications
You must be signed in to change notification settings - Fork 2
Component-architecture #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bacalj
wants to merge
29
commits into
main
Choose a base branch
from
component-architecture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove containerRef dependency and auto-detect target bot containers to support multiple QA bots on the same page.
…t compatibility - Change FileUploadComponent from pre-rendered JSX to function components - Update createFileUploadComponent in ticket-flow-utils.js to return named function - Convert inline fileUploadElement in feedback-flow.js and security-flow.js to functions - Update LoginButton usage in create-bot-flow.js and useChatBotSettings.js to use functions - Add displayName to FileUploadWrapper for React DevTools compliance
- Update react-chatbotify from v2.1.0 to v2.2.0 for better cross-environment compatibility - Convert custom components to function-based patterns for Drupal/Preact compatibility - Add deployment tracking console signature - Fix FileUpload components in feedback, security, and ticket flows
- Convert remaining FileUpload components to function-based pattern - Update createFileUploadComponent in ticket-flow-utils.js to return named function - Convert fileUploadElement in feedback-flow.js to function-based - Update LoginButton in useChatBotSettings.js buttons array to function-based All custom components now use function-based pattern for better cross-environment compatibility with react-chatbotify v2.2.0
Replace problematic custom components with built-in react-chatbotify features: - Replace FileUploadComponent with built-in file upload using file attribute - Enable FILE_ATTACHMENT_BUTTON in footer with fileAttachment settings - Replace LoginButton with HTML link in login flow message - Replace UserIcon with text in header button - Remove all custom component imports and declarations This should resolve React→Preact→Drupal compatibility issues by eliminating custom component rendering in favor of native react-chatbotify functionality.
- Make submitTicket return actual success/failure result instead of using closure variables - Update all ticket flows to check returned result before navigation - Add proper error flows for failed submissions with retry options - Store results locally for better cross-environment reliability This should fix the issue where frontend shows failure but backend succeeds in React→Preact→Drupal environments by making submission completion synchronous with navigation decisions.
✅ Deploy Preview for access-qa-bot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…for debugging in drupal via access-ci-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR to demonstrate the use of the non-custom-component version of the upload workflow, which is more compatible with the preact wrapping