Skip to content

Conversation

@l-heemann
Copy link
Contributor

@l-heemann l-heemann commented Nov 12, 2025

https://linear.app/neo4j/issue/COPS-301/update-to-notification-cannot-deny-with-auth-rule

The trello/linear template says

Docs for new status code should
have a table with code, title, severity and category

But I didn't find one for other codes?

Documents error codes introduced in https://github.com/neo-technology/neo4j/pull/33422

= Changes to status codes per Neo4j version

// TODO don't know release date yet
== Neo4j 2025.XX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a comment for @renetapopova I do not think we have added all new GQLSTATUS codes here, at least for errors. The ones for notifications we have added though. Do we need some better guidelines around this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding from the discussion yesterday is that we are removing the changelog anyway, so I have removed the changes to this file.

@@ -0,0 +1,62 @@
// TODO don't know release date yet
:page-role: new-2025.XX
= 22N81
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened to spot on the preview-message: you have a copy-paste error here in both new pages

@renetapopova renetapopova self-assigned this Nov 18, 2025
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @l-heemann. I added some editorial suggestions.


== Possible solutions
Consider if it is possible to implement the security model without using denied privileges.
Often it is possible to revoke granted privileges or reducing the scope of grant statements.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Often it is possible to revoke granted privileges or reducing the scope of grant statements.


== Possible solutions
Consider if it is possible to implement the security model without using denied privileges.
Often it is possible to revoke granted privileges or reducing the scope of grant statements.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Often it is possible to revoke granted privileges or reducing the scope of grant statements.

Consider if it is possible to implement the security model without using denied privileges.
Often it is possible to revoke granted privileges or reducing the scope of grant statements.

In the example above, a generic grant such as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above to refer to the query in the Example scenario instead of repeating it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this update for both pages as a separate PR, please re-review to see if I got it right, thanks :)


Status description:: error: data exception - property value too big. Property value of type `{ <<typeDescription>> }` is too big (more than `{ <<bytes>> }` bytes): `{ <<value>> }`

// TODO don't know release date yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated from the actual code files. Don't need to update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad, looks like you fixed it?

@renetapopova renetapopova force-pushed the cops-301-update-to-notification-cannot-deny-with-auth-rule branch from 2afc27e to c2273f6 Compare November 19, 2025 16:09
l-heemann and others added 2 commits November 20, 2025 09:18
Applied straightforward suggestions, leaving some suggestions that require more thought

Co-authored-by: Reneta Popova <[email protected]>
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all should be fine now.

@renetapopova
Copy link
Collaborator

@l-heemann, which version should those be merged into?

@neo4j-docops-agent
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-412.surge.sh

New pages:

Updated pages:

@l-heemann
Copy link
Contributor Author

@l-heemann, which version should those be merged into?

@renetapopova The main feature has been merged to dev (2025.12.0) but it is behind a feature flag so customers can reach it at the earliest some time next year, unless they enable a feature flag. So far only a handful of customers know about the feature. 🤷

@renetapopova
Copy link
Collaborator

@l-heemann, which version should those be merged into?

@renetapopova The main feature has been merged to dev (2025.12.0) but it is behind a feature flag so customers can reach it at the earliest some time next year, unless they enable a feature flag. So far only a handful of customers know about the feature. 🤷

But given that nobody will see this error unless they are using the feature, I think it's safe to merge it when we publish 2025.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants