-
Notifications
You must be signed in to change notification settings - Fork 36
Add 22ND1 and 22ND2 #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add 22ND1 and 22ND2 #412
Conversation
modules/ROOT/pages/changelogs.adoc
Outdated
| = Changes to status codes per Neo4j version | ||
|
|
||
| // TODO don't know release date yet | ||
| == Neo4j 2025.XX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More a comment for @renetapopova I do not think we have added all new GQLSTATUS codes here, at least for errors. The ones for notifications we have added though. Do we need some better guidelines around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding from the discussion yesterday is that we are removing the changelog anyway, so I have removed the changes to this file.
| @@ -0,0 +1,62 @@ | |||
| // TODO don't know release date yet | |||
| :page-role: new-2025.XX | |||
| = 22N81 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happened to spot on the preview-message: you have a copy-paste error here in both new pages
renetapopova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @l-heemann. I added some editorial suggestions.
|
|
||
| == Possible solutions | ||
| Consider if it is possible to implement the security model without using denied privileges. | ||
| Often it is possible to revoke granted privileges or reducing the scope of grant statements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Often it is possible to revoke granted privileges or reducing the scope of grant statements. |
|
|
||
| == Possible solutions | ||
| Consider if it is possible to implement the security model without using denied privileges. | ||
| Often it is possible to revoke granted privileges or reducing the scope of grant statements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Often it is possible to revoke granted privileges or reducing the scope of grant statements. |
| Consider if it is possible to implement the security model without using denied privileges. | ||
| Often it is possible to revoke granted privileges or reducing the scope of grant statements. | ||
|
|
||
| In the example above, a generic grant such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above to refer to the query in the Example scenario instead of repeating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this update for both pages as a separate PR, please re-review to see if I got it right, thanks :)
|
|
||
| Status description:: error: data exception - property value too big. Property value of type `{ <<typeDescription>> }` is too big (more than `{ <<bytes>> }` bytes): `{ <<value>> }` | ||
|
|
||
| // TODO don't know release date yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated from the actual code files. Don't need to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, looks like you fixed it?
Roles are not allowed to have denied privileges and auth rules at the same time
2afc27e to
c2273f6
Compare
Applied straightforward suggestions, leaving some suggestions that require more thought Co-authored-by: Reneta Popova <[email protected]>
renetapopova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all should be fine now.
|
@l-heemann, which version should those be merged into? |
|
This PR includes documentation updates New pages: Updated pages: |
@renetapopova The main feature has been merged to dev (2025.12.0) but it is behind a feature flag so customers can reach it at the earliest some time next year, unless they enable a feature flag. So far only a handful of customers know about the feature. 🤷 |
But given that nobody will see this error unless they are using the feature, I think it's safe to merge it when we publish 2025.12. |
https://linear.app/neo4j/issue/COPS-301/update-to-notification-cannot-deny-with-auth-rule
The trello/linear template says
But I didn't find one for other codes?
Documents error codes introduced in https://github.com/neo-technology/neo4j/pull/33422