Fix for incorrect reporting of a type mismatch when object mapping fails and a Vector type is involved. #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils and a Vector type is involved. Before the fix the error reported when trying to map from, for example, a Vector<float> to a Vector<double> was: System.InvalidOperationException: The expected value `Neo4j.Driver.Vector`1[System.Single]` is different from the actual value `System.Collections.Generic.List`1[System.Single]` This was occurring because the ValueExtensions As method did not contain a clause for IVector, this caused the logic to fall through to the IEnumerable clause (which a vector implements) which converted the vector into a list, and then failed the type conversion on that list. Now that a clause for IVector is added you get the correct error. e.g. For the Vector<float> -> Vector<double> example: System.InvalidOperationException: The expected value `Neo4j.Driver.Vector`1[System.Single]` is different from the actual value `Neo4j.Driver.Vector`1[System.Double]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix the error reported when trying to map from, for example, a Vector to a Vector was:
System.InvalidOperationException: The expected value 'Neo4j.Driver.Vector'1[System.Single]' is different from the actual value 'System.Collections.Generic.List'1[System.Single]'This was occurring because the ValueExtensions As method did not contain a clause for IVector, this caused the logic to fall through to the IEnumerable clause (which a vector implements) which converted the vector into a list, and then failed the type conversion on that list.
Now that a clause for IVector is added you get the correct error. e.g. For the Vector -> Vector example:
System.InvalidOperationException: The expected value 'Neo4j.Driver.Vector'1[System.Single]' is different from the actual value 'Neo4j.Driver.Vector'1[System.Double]'