Skip to content

Conversation

sravani1510
Copy link
Contributor

@sravani1510 sravani1510 commented Sep 30, 2025

similar to aix IBM i does not support certain network flags we are getting the following build errors:

../deps/ngtcp2/ngtcp2/examples/shared.cc:68:63: error:
 'IPTOS_ECN_MASK' was not declared in this scope
   68 |         return *reinterpret_cast<uint8_t *>(CMSG_DATA(cmsg))
    & IPTOS_ECN_MASK;
      |                                                              
       ^~~~~~~~~~~~~~
../deps/ngtcp2/ngtcp2/examples/shared.cc:80:22: error:
 'IPTOS_ECN_MASK' was not declared in this scope
   80 |         return tos & IPTOS_ECN_MASK;
      |                      ^~~~~~~~~~~~~~

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 30, 2025
@abmusse abmusse added the ibm i Issues and PRs related to the IBM i platform. label Sep 30, 2025
@sravani1510
Copy link
Contributor Author

CC

@nodejs/platform-ibmi

@richardlau
Copy link
Member

@sravani1510 Would you be able to change the commit message to "build: fix flags for ngtcp2 on IBM i"? (Or something similar, the important bit is that we don't use the "fix:" prefix here -- see our commit message guidelines.)

@sravani1510 sravani1510 changed the title fix: flags for ngtcp2 on IBM i build: fix flags for ngtcp2 on IBM i Sep 30, 2025
@abmusse
Copy link
Contributor

abmusse commented Sep 30, 2025

Test Build: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2095/console

We will also need to skip the tests like on AIX.

See: #60064

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 1, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit 0eda17b into nodejs:main Oct 2, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0eda17b

@sravani1510 sravani1510 deleted the ibmi-ngtcp2.gyp branch October 6, 2025 10:27
@targos targos added the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label Oct 6, 2025
@targos
Copy link
Member

targos commented Oct 6, 2025

depends on #59946

@richardlau richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants