-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
build: fix flags for ngtcp2 on IBM i #60073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
CC @nodejs/platform-ibmi |
@sravani1510 Would you be able to change the commit message to "build: fix flags for ngtcp2 on IBM i"? (Or something similar, the important bit is that we don't use the "fix:" prefix here -- see our commit message guidelines.) |
Test Build: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2095/console We will also need to skip the tests like on AIX. See: #60064 |
7efaf79
to
2ea850a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 0eda17b |
depends on #59946 |
similar to aix IBM i does not support certain network flags we are getting the following build errors: