lib: remove redundant destroyHook checks #60120
Open
+8
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitDestroy
already checks these now:node/lib/internal/async_hooks.js
Lines 533 to 538 in 6f941fc
We are essentially checking the same condition twice
Also the invalid id check didn't cover
undefined
. I don't know if it was intentional, but in any case, since #56966, which removedenroll
, I'm not sure if we can have an undefinedasyncId
anyway