-
Notifications
You must be signed in to change notification settings - Fork 110
Docs content for the throttle step #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for docs-novu failed. Why did it fail? →
|
WalkthroughAdds a new Throttle Step documentation page and updates the platform docs navigation to include it. No code or behavior changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
public/images/workflows/dynamic-window.png
is excluded by!**/*.png
public/images/workflows/fixed-window.png
is excluded by!**/*.png
public/images/workflows/throttle-step-activity-feed.png
is excluded by!**/*.png
📒 Files selected for processing (2)
content/docs/platform/meta.json
(1 hunks)content/docs/platform/workflow/throttle-step.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Lint
🔇 Additional comments (1)
content/docs/platform/meta.json (1)
31-31
: Entry looks goodThe throttle step page is now discoverable alongside the other workflow docs, consistent with the existing slug conventions.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@@ -0,0 +1,82 @@ | |||
--- | |||
title: 'Throttle Step' | |||
description: 'Learn how to use the Throttle step in Novu workflows to control notification frequency.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not capitalize every instance of "throttle." Apply throughout.
|
||
To the subscriber, the experience is transparent. They are not aware that any throttling has occurred; they either receive a notification or they don’t. The subscriber is never exposed to information about the throttle itself. | ||
|
||
## Configuration options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing this heading and the intro paragraph following it. They don't add much value, and without them, you can move the following headings up a level and avoid going down to h4.
|
||
The Throttle step has several configuration fields that define how throttling is applied. | ||
|
||
### Throttle Step properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do I find these properties?
Same question for Throttle window.
Co-authored-by: DianaHackmamba <[email protected]>
Co-authored-by: DianaHackmamba <[email protected]>
Co-authored-by: DianaHackmamba <[email protected]>
Co-authored-by: DianaHackmamba <[email protected]>
Co-authored-by: DianaHackmamba <[email protected]>
Summary by CodeRabbit