Add normalize language function and tests

_tests/test_createJson.py

@@ -10,7 +10,8 @@
 import json
 from _validate import (
 	createJson,
-	addonManifest
+	addonManifest,
+	manifestLoader
 )
 
 TOP_DIR = os.path.abspath(os.path.dirname(__file__))
@@ -110,3 +111,19 @@ def test_validVersion(self):
 			"1.2.0.json",
 			msg="Name of the output file should be named based on version number"
 		)
+
+
+class Test_normalizeLanguage(unittest.TestCase):
+	"""Set of unit tests for `manifestLoader.normalizeLanguage`."""
+
+	def test_normalization_no_country_info(self):
+		"""Makes sure that if no country info is provided language is normalized to lower case."""
+		self.assertEqual("en", manifestLoader.normalizeLanguage("en"))
+		self.assertEqual("en", manifestLoader.normalizeLanguage("EN"))
+		self.assertEqual("kmr", manifestLoader.normalizeLanguage("kmr"))
+
+	def test_underscore_used_as_separator_after_normalization(self):
+		"""Ensures that underscore is used to separate country info from language.
+		Also implicitly test the fact that country code is converted to upper case."""
+		self.assertEqual("pt_BR", manifestLoader.normalizeLanguage("pt_BR"))
+		self.assertEqual("pt_BR", manifestLoader.normalizeLanguage("pt-BR"))

_validate/manifestLoader.py

@@ -47,6 +47,22 @@ def getAddonManifestLocalizations(
 		languageCode = pathlib.Path(translationFile).parent.name
 		try:
 			translatedManifest = AddonManifest(translationFile)
-			yield languageCode, translatedManifest
+			yield normalizeLanguage(languageCode), translatedManifest
 		except Exception:
 			print(f"Error in {translationFile}")
+
+
+def normalizeLanguage(lang: str) -> str:
+	"""
+	Normalizes a language-dialect string  into a standard form we can deal with.
+	Converts any dash to underline, and makes sure that language is lowercase and dialect is uppercase.
+	Based on NVDA`s `languageHandler` module.
+	:param lang: A language code.
+	:return: A normalized language code.
+	"""
+	lang = lang.replace("-", "_")
+	ld = lang.split("_")
+	ld[0] = ld[0].lower()
+	if len(ld) >= 2:
+		ld[1] = ld[1].upper()
+	return "_".join(ld)