-
Notifications
You must be signed in to change notification settings - Fork 21
Remove add-ons IDs with spaces #5975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi folks, You've been tagged in this message due to an unfortunate issue with the status of your add-ons in the NVDA add-on store. This need was unfortunately not documented very well, nor enforced very well. We have now added automated checks to prevent add-on IDs with spaces in them (and other formatting issues) from being submitted. Please note, that due to the change in add-on ID, users won't be able to automatically update to the new add-on ID. They will have install the new add-on, and uninstall the old add-on. I apologise for the inconvenience this will cause for yourself as developers and your users. As the bugs with add-on IDs with spaces are not severe, we do not need to remove your existing add-ons in the immediate future. These are the following add-ons affected:
|
Signed-off-by: Sean Budd <[email protected]>
Signed-off-by: Sean Budd <[email protected]>
How do I remove the existing non conforming addon from the store? |
@krishnshyam - if you wish to do this, open a PR similar to this PR. However, I am happy to do this for you when the new add-on is released to the store |
Hi @seanbudd, my new add-on version has been accepted and is now in the store. Thank you! |
Signed-off-by: Sean Budd <[email protected]>
@AndhiMardianto @krishnshyam - that has been done now |
@s-toolkit @techvisionaryteam do you plan on addressing this soon? it might be good for your users to fix this ASAP, before many users install your add-ons, as your add-ons were submitted relatively recently |
We've been accepting add-on IDs with spaces.
This breaks parts of our validation and submission process.
This will be prevented in nvaccess/addon-datastore-validation#44
Unfortunately this requires the removal of several add-ons from the store.
Authors will be contacted and encouraged to resubmit with valid add-on IDs before this is merged