Skip to content

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jul 6, 2018

At least on my FreeBSD-11 system, patch 0003 results in an empty META file which is then installed - leading to an unusable nocrypto. Would be nice if next time someone "unbreaks" this on Free/OpenBSD, they'd test their changes.

see #12062 #12252 #12253
//cc @copy @hcarty @mseri

@camelus
Copy link
Contributor

camelus commented Jul 6, 2018

✅ All lint checks passed 37e66df
  • These packages passed lint tests: nocrypto.0.5.4-1

✅ Installability check (9066 → 9066)

@copy
Copy link
Contributor

copy commented Jul 6, 2018

Sorry! I should have pinged someone for testing on the BSDs before getting another non-applying patch merged.

Considering how different BSD and GNU apply are, it's probably better if this was fixed by using git apply (ocaml/opam#2160).

@hannesm hannesm merged commit 2a4e327 into ocaml:master Jul 7, 2018
@hannesm hannesm deleted the nocrypto-freebsd branch July 7, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants