Skip to content

Conversation

jmid
Copy link
Member

@jmid jmid commented Sep 12, 2025

The sausage factory continues... πŸ§‘β€πŸ­

I spotted a SDL2_ttf Windows failures recently on #28326 motivating this.

The installed MinGW packages are

The most exciting part is that the latter supports i686, compared to #28507

Again, while at it, I added Cygwin support based on https://cygwin.com/packages/summary/libSDL2_ttf-devel.html

I've tested the changes (incl. MSys2) with a self-PR here: jmid#10

@smorimoto smorimoto requested a review from Copilot September 12, 2025 13:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds MinGW and Cygwin support for SDL2_ttf by creating architecture-specific MinGW packages and updating the main configuration to handle Windows cross-compilation scenarios.

  • Creates separate MinGW packages for i686 and x86_64 architectures with appropriate pkg-config personalities
  • Updates the main SDL2_ttf configuration to conditionally use pkgconf with MinGW personalities on Windows
  • Adds Cygwin support with native SDL2_ttf package dependency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/conf-sdl2-ttf/conf-sdl2-ttf.1/opam Updates build commands and dependencies to support MinGW cross-compilation and adds Cygwin depext
packages/conf-mingw-w64-sdl2-ttf-x86_64/conf-mingw-w64-sdl2-ttf-x86_64.1/opam New package providing x86_64 MinGW SDL2_ttf support with Cygwin and MSys2 depexts
packages/conf-mingw-w64-sdl2-ttf-i686/conf-mingw-w64-sdl2-ttf-i686.1/opam New package providing i686 MinGW SDL2_ttf support with Cygwin and MSys2 depexts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@smorimoto smorimoto merged commit 0ae7845 into ocaml:master Sep 12, 2025
2 of 3 checks passed
@jmid jmid deleted the mingw-sdl2-ttf branch September 12, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants