Add a dune upper bound for tezt 3.1.0-4.2.0 with-test #28550
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a number of PRs I've observed
tezt
failures to runwith-test
, e.g., on #28437https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/c56e58d25e43ce7dd35f9942ad32b42e22d608c9
and now again today on #28544
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/8165ebc987d9de35b2fdba552fd80e37f5bd842d
The issue turns out to be caused by
dune.3.19.0
changing the observed value ofSys.argv.(0)
- which happens to be printed in the test suite (in cram tests) of tezt 3.1.0-4.2.0 ocaml/dune#11881I've confirmed locally that
opam install tezt --with-test
installs cleanly with dune.3.18.2 and below.According to the above issue the change of behaviour should be rolled back with dune.3.19.1, however
locally with ocaml.4.14.2, dune.3.19.1, and tezt.4.2.0 I still observe test failures:
I've therefore gone with a hard < 3.19.0 bound for all 5 tezt version where we've observed the failure.
Note: this is not a hard bound - only a bound for where we run the tezt testsuite.