Bug correction in dokeysto.4.0.2 impacting three packages #28567
Conversation
dokeysto, dokeysto_camltc, dokeysto_lz4
There was a problem hiding this comment.
Thanks!
CI is failing
- on opam-2.0 (these can be ignored)
- on Fedora-42 (which looks like an internal CI issue)
- on x86_32-ocaml-4.14 running the test suite for
dokeysto_camltcwithFatal error: exception Failure("stat error"). The package installs cleanly though. - on Windows compiling
dokeysto_camltc - on Windows installing
mingw-w64-shims.0.2.0
Potentially we could add
available: os != "win32"fordokeysto_camltcand- guard
with-testfordokeysto_camltcwitharch != "x86_32"
Finally: Would you consider adding x-maintenance-intent entries for these packages?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md
|
@jmid if you can make your suggestions directly as modifications of the opam files, it would be nice (edits are allowed by maintainers). |
There was a problem hiding this comment.
@jmid if you can make your suggestions directly as modifications of the opam files, it would be nice (edits are allowed by maintainers).
OK, I've made the suggestions inline now 👍
I don't have write permissions and/or full maintainer rights (yet), so you or someone else will have to apply them 🤷
| license: "LGPL-2.1-only" | ||
| build: [ | ||
| ["dune" "build" "-p" name "-j" jobs] | ||
| ["dune" "exec" "-p" name "-j" jobs "src/test_camltc.exe"] {with-test} |
There was a problem hiding this comment.
| ["dune" "exec" "-p" name "-j" jobs "src/test_camltc.exe"] {with-test} | |
| ["dune" "exec" "-p" name "-j" jobs "src/test_camltc.exe"] {with-test & arch != "x86_32"} |
#=== ERROR while compiling dokeysto_camltc.4.0.2 ==============================#
# context 2.4.1 | linux/x86_32 | ocaml-base-compiler.4.14.2 | pinned(https://github.com/UnixJunkie/dokeysto/archive/v4.0.2.tar.gz)
# path ~/.opam/4.14/.opam-switch/build/dokeysto_camltc.4.0.2
# command ~/.opam/opam-init/hooks/sandbox.sh build dune exec -p dokeysto_camltc -j 255 src/test_camltc.exe
# exit-code 2
# env-file ~/.opam/log/dokeysto_camltc-7-3e5cd1.env
# output-file ~/.opam/log/dokeysto_camltc-7-3e5cd1.out
### output ###
# Fatal error: exception Failure("stat error")
|
thanks a lot @jmid ; I am not aware of the latest syntax and required tags in opam files, so this is very useful. |
modified: dokeysto/dokeysto.4.0.2/opam modified: dokeysto_camltc/dokeysto_camltc.4.0.2/opam modified: dokeysto_lz4/dokeysto_lz4.4.0.2/opam
|
fixes have been applied |
dokeysto, dokeysto_camltc, dokeysto_lz4
Any software relying on dokeysto should use this new version (4.0.2).
Really stupid use of Unix.read somewhere replaced by a really_read function (like Stdlib.really_input but for Unix file descriptors).