-
Notifications
You must be signed in to change notification settings - Fork 80
Opam Onboarding #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Opam Onboarding #1737
Conversation
We should add the survey link in the onboarding. Maybe also in the status bar / command panel in a separate PR ? |
It may be better to write the alt text more properly, or to leave it blank at all. We can come up with some ideas about that for accessibility. |
Is there a way to automatically check the various steps at the end of command execution ? |
Indeed. I think the best way is to check if opam is installed and just move to the next step or exit the onboarding with a toast explaining opam is already installed |
Yes, this is now available. |
Hi @PizieDust , this looks awesome! It could significantly improve the experience of people setting up OCaml. Would it be easy to drop a quick screencast of the walkthrough here? I'll review the code next week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we should merge this rather sooner than later and see what feedback we get.
Is the following comment from above already adressed?
Ideally we would also not permit users to "install opam" if they already have opam installed...
e84abda
to
34ae24f
Compare
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
34ae24f
to
cf54ef3
Compare
@smorimoto Have you been able to try this out? I'm curious to get your observations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smorimoto , what do you think? IMO if there's no reason why not to merge this, we should merge it to get some feedback :)
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
@smorimoto Hi Sora. The merge conflicts are fixed now |
Hi @smorimoto , I was wondering: Is there anything we haven't noticed that is blocking this from getting merged? |
I don't think so, but basically I'm not in a position to decide when we add a new feature though. |
This PR introduces a new way to onboard users into the OCaml ecosystem.
It uses a short interactive tutorial to guide the user through the various steps of setting up OCaml.
cc @voodoos