-
Notifications
You must be signed in to change notification settings - Fork 6
fix get release date #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix get release date #109
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alokgoswami-ag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e6c9e07
to
f76bf9e
Compare
Overall LGTM, few suggestions added as comment |
fd6d6e4
to
89ed2eb
Compare
monitor.py
Outdated
sys.exit(1) | ||
if response.status_code == 200: | ||
soup = BeautifulSoup(response.text, 'html.parser') | ||
form = soup.find("form", {"method": "GET"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify if we can have only one form in a page and if not handle that multiple form elements as well
Signed-off-by: alokgoswami-ag <[email protected]>
Signed-off-by: alokgoswami-ag <[email protected]>
Signed-off-by: alokgoswami-ag <[email protected]>
89ed2eb
to
bca9916
Compare
This PR enhances the fetch_release_date function in the automation script to handle cases where the release "Created" date is not directly available on the release page.
It now includes fallback logic to extract the created date from the changelog (https://ppc64le.ocp.releases.ci.openshift.org/changelog) when required.