Skip to content

changing callback_path to callback_url to account for relative root url #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changing callback_path to callback_url to account for relative root url #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/omniauth/strategies/ldap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class MissingCredentialsError < StandardError; end

def request_phase
OmniAuth::LDAP::Adaptor.validate @options
f = OmniAuth::Form.new(:title => (options[:title] || "LDAP Authentication"), :url => callback_path)
f = OmniAuth::Form.new(:title => (options[:title] || "LDAP Authentication"), :url => callback_url)
f.text_field 'Login', 'username'
f.password_field 'Password', 'password'
f.button "Sign In"
Expand Down
2 changes: 1 addition & 1 deletion spec/omniauth/strategies/ldap_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def session
end

it 'should have the callback as the action for the form' do
last_response.body.should be_include("action='/auth/ldap/callback'")
last_response.body.should be_include("action='http://example.org/auth/ldap/callback'")
end

it 'should have a text field for each of the fields' do
Expand Down