Skip to content

Thread safety fix in logging and SetLevel #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Thread safety fix in logging and SetLevel #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions level.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ type LeveledBackend interface {
}

type moduleLeveled struct {
sync.RWMutex
levels map[string]Level
backend Backend
formatter Formatter
Expand All @@ -88,6 +89,8 @@ func AddModuleLevel(backend Backend) LeveledBackend {

// GetLevel returns the log level for the given module.
func (l *moduleLeveled) GetLevel(module string) Level {
l.RLock()
defer l.RUnlock()
level, exists := l.levels[module]
if exists == false {
level, exists = l.levels[""]
Expand All @@ -101,6 +104,8 @@ func (l *moduleLeveled) GetLevel(module string) Level {

// SetLevel sets the log level for the given module.
func (l *moduleLeveled) SetLevel(level Level, module string) {
l.Lock()
defer l.Unlock()
l.levels[module] = level
}

Expand Down
14 changes: 14 additions & 0 deletions logger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,17 @@ func TestPrivateBackend(t *testing.T) {
t.Error("logged to defaultBackend:", MemoryRecordN(privateBackend, 0))
}
}

func TestConcurrency(t *testing.T) {
logger := MustGetLogger("test")
go func() {
for i := 0; i < 1000; i++ {
SetLevel(Level(DEBUG), "test")
}
}()

for i := 0; i < 1000; i++ {
logger.Info("")
}
}