Skip to content

Conversation

arkirchner
Copy link
Contributor

The system test is unstable. Revert for now to allow the CI to pass.

Reverts #3008

@arkirchner arkirchner self-assigned this Aug 7, 2025
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.08%. Comparing base (caccb8a) to head (beba994).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
- Coverage   70.18%   70.08%   -0.11%     
==========================================
  Files         215      215              
  Lines        6850     6850              
==========================================
- Hits         4808     4801       -7     
- Misses       2042     2049       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1,162 +0,0 @@
# frozen_string_literal: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I understand that the test is flaky.
Could we use other measures than removing it entirely? I'm thinking about retrying it or marking it as flaky.

Copy link
Contributor Author

@arkirchner arkirchner Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing me to check this more deeply. We recently switched from Chrome to Firefox in the CI. Reverting this fixed the issue.

We were switching to Firefox because there were issues with Chrome. They seem to be solved. We can switch back to Chrome.

Can you review: openHPI/codeharbor#2105 and #3067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants