Skip to content

Initial cleanup of test setup. #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Initial cleanup of test setup. #587

wants to merge 3 commits into from

Conversation

@MikeNeilson
Copy link
Collaborator

@MikeNeilson MikeNeilson commented Nov 16, 2025 •
edited
Loading

Problem Description

Fixes #191 .
depends on opendcs/opendcs#1511

Describe the problem you are trying to solve.

Solution

  • simplify or clean up test setup
  • remove special case check of database props
  • Set "database type" in various locations to the new format.

how you tested the change

No application level behavioral changes. Integration tests themselves are untouched.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@MikeNeilson MikeNeilson linked an issue Nov 16, 2025 that may be closed by this pull request
Move database type along with relevant metadata to the database schema #191
Open
@MikeNeilson MikeNeilson force-pushed the devops/cleanup-test-infra branch from 1029b0b to f0b4026 Compare November 16, 2025 17:22
@MikeNeilson MikeNeilson force-pushed the devops/cleanup-test-infra branch from f0b4026 to eff34f8 Compare November 16, 2025 17:24
@MikeNeilson
Move integration tests towards main code standards
40c32a0 
* Latest RC
* Properties in DB
* remove useless test (behavior is already tested in setup)
* Setup DatabaseTypeEnum with mappings to new and old implementation
  names
* rename source directory to new implementatio names.
@MikeNeilson
Remove 'backup' database setup code.
49c96a7
@MikeNeilson MikeNeilson marked this pull request as ready for review November 21, 2025 22:46
@MikeNeilson MikeNeilson changed the title WIP, initial cleanup of test setup. Initial cleanup of test setup. Nov 21, 2025
@MikeNeilson MikeNeilson requested a review from a team November 21, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamkorynta adamkorynta adamkorynta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move database type along with relevant metadata to the database schema

3 participants

@MikeNeilson @adamkorynta