Skip to content

Conversation

@AndrewChubatiuk
Copy link

@AndrewChubatiuk AndrewChubatiuk commented Jul 2, 2025

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma @jcantrill
/assign @jcantrill

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2025
@openshift-ci-robot
Copy link

@AndrewChubatiuk: This pull request explicitly references no jira issue.

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables log events framing separating events with a newline

/cc @Clee2691 @cahartma
/assign @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Clee2691 and cahartma July 2, 2025 10:37
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

Hi @AndrewChubatiuk. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrutkovs
Copy link

vrutkovs commented Jul 2, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2025
@jcantrill
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewChubatiuk
Once this PR has been reviewed and has the lgtm label, please ask for approval from cahartma. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 2 times, most recently from 51ccd76 to 2e5417c Compare September 25, 2025 20:01
@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 2 times, most recently from 85b5c6b to fdc25c0 Compare October 14, 2025 10:05
@jcantrill
Copy link
Contributor

@AndrewChubatiuk are you still interested in submitting this contribution? If so, we'll need to create a tracking issue and review the API

@AndrewChubatiuk
Copy link
Author

AndrewChubatiuk commented Oct 15, 2025

are you still interested in submitting this contribution? If so, we'll need to create a tracking issue and review the API

yes, interested in this as well

@vrutkovs
Copy link

vrutkovs commented Oct 16, 2025

/retitle LOG-7892: support NDJSON for http sink

@openshift-ci openshift-ci bot changed the title NO-JIRA: support NDJSON for http sink LOG-7892: support NDJSON for http sink Oct 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma
/assign @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 2 times, most recently from 21e01f6 to 8d8aa0f Compare October 17, 2025 04:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

@AndrewChubatiuk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma @jcantrill
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release/6.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants