-
Notifications
You must be signed in to change notification settings - Fork 167
LOG-7892: support NDJSON for http sink #3074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@AndrewChubatiuk: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @AndrewChubatiuk. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/hold |
141b737 to
d00dd86
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrewChubatiuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
51ccd76 to
2e5417c
Compare
85b5c6b to
fdc25c0
Compare
|
@AndrewChubatiuk are you still interested in submitting this contribution? If so, we'll need to create a tracking issue and review the API |
fdc25c0 to
e7abcaa
Compare
yes, interested in this as well |
e7abcaa to
85bd3c0
Compare
|
/retitle LOG-7892: support NDJSON for http sink |
|
@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
21e01f6 to
8d8aa0f
Compare
8d8aa0f to
d81fe1f
Compare
|
@AndrewChubatiuk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added
line_per_eventboolean argument for HTTP sink, which enables NDJSON format for HTTP sink eventsrebased it against #3073
since both PR share same functional tests code
/cc @Clee2691 @cahartma @jcantrill
/assign @jcantrill