Skip to content

Conversation

@Clee2691
Copy link
Contributor

Description

This PR decouples Lokistack labels from Loki.

For Lokistack:

  • App and infra logs will include log type, host, and container labels along with their Otel equivalents.
  • Audit logs will NOT include container labels but will include log type and host labels along with their Otel equivalents.

For Loki:

  • log type, host, and container labels will be added by default without their Otel equivalents if no LabelKeys are defined.

/cc @cahartma @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@Clee2691: This pull request references LOG-7889 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR decouples Lokistack labels from Loki.

For Lokistack:

  • App and infra logs will include log type, host, and container labels along with their Otel equivalents.
  • Audit logs will NOT include container labels but will include log type and host labels along with their Otel equivalents.

For Loki:

  • log type, host, and container labels will be added by default without their Otel equivalents if no LabelKeys are defined.

/cc @cahartma @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from cahartma and vparfonov October 28, 2025 02:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Clee2691
Once this PR has been reviewed and has the lgtm label, please assign alanconway for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Clee2691
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. release/6.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants