Skip to content

Conversation

hwf1324
Copy link
Contributor

@hwf1324 hwf1324 commented Mar 22, 2024

Manually set the proportion property of description.sizer to 1 and set flag=wx.EXPAND when adding self.description.sizer to contentsSizer.
Set the size of the dialog box and reduce the height of ListBox to increase the height of TextCtrl.
Change "Event &description" to "Event\n&description" to increase the width of the description.

Closes #3

@XLTechie
Copy link
Collaborator

Change "Event &description" to "Event\n&description" to increase the width of the description.

As a newline, wouldn't that increase the height not the width? Shouldn't it be a \t instead?

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 22, 2024

Change "Event &description" to "Event\n&description" to increase the width of the description.

As a newline, wouldn't that increase the height not the width? Shouldn't it be a \t instead?

No, the static text control label extrudes the text control that actually displays the event description.

@XLTechie
Copy link
Collaborator

@hwf1324 Why the change to the way gui was imported? Actually, you removed the gui import, which doesn't stop it from working, but it's unusual to use parts of a module relying on implied imports.

I'm going to go back to importing gui, and use guiHelper with a from gui import guiHelper, unless you know of something broken by doing that.

Also, you should update your fork; you're several commits behind.

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 22, 2024

@XLTechie

size=self.scaleSize((500, 300)), # height is chosen to ensure the dialog will fit on an 800x600 screen,

Based on the description of the comment, how can I adjust it so that the TextCtrl is higher to show more content?

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 22, 2024

Why the change to the way gui was imported? Actually, you removed the gui import, which doesn't stop it from working, but it's unusual to use parts of a module relying on implied imports.

This was done because the language server could not find a definition for guiHelper. In fact import gui.guiHelper will have both gui and gui.guiHelper variables in global space.

I'm going to go back to importing gui, and use guiHelper with a from gui import guiHelper, unless you know of something broken by doing that.

If this is done, then all calls to gui.guiHelper may have to be changed to guiHelper.

@XLTechie
Copy link
Collaborator

This was done because the language server could not find a definition for guiHelper.

Language server? I do not understand.

In fact import gui.guiHelper will have both gui and gui.guiHelper variables in global space.

It does, but as I said it is not standard.

I'm going to go back to importing gui, and use guiHelper with a from gui import guiHelper, unless you know of something broken by doing that.

If this is done, then all calls to gui.guiHelper may have to be changed to guiHelper.

Yes. I did that indeed.
Here is a dev build containing your latest change, with my minor modifications.

@XLTechie
Copy link
Collaborator

XLTechie commented Mar 22, 2024 via email

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 22, 2024

Meaning as long as the GUI is not larger than 800x600? There is no other special meaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The size of the Event description TextCtrl is too small. Can the proportion attribute be set to 1?
2 participants