BUILD: Add stub include path for gdaki #10971
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeynmann
changed the title
stubs/uct/ib/mlx5/gdaki/gdaki.cuh
Outdated
| @@ -0,0 +1,101 @@ | |||
| /** | |||
| * Copyright (c) NVIDIA CORPORATION & AFFILIATES, 2025. ALL RIGHTS RESERVED. | |||
| * | |||
There was a problem hiding this comment.
no need this space
stubs/uct/ib/mlx5/gdaki/gdaki_dev.h
Outdated
|
|
||
|
|
||
| typedef struct { | ||
| uct_device_ep_t super; |
There was a problem hiding this comment.
I think only uct_rc_gda_completion_t is needed and it might be empty
Artemy-Mellanox
approved these changes
Oct 25, 2025
ofirfarjun7
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Stub headers for gdaki.
Why?
Ucx device app may build failed if ucx-ib-mlx5-gda not installed,
because ucx device api include gdaki's header directly.
How?
Add stub dir to ucx include path.
The stub dir has low prior so compiler can find real impl header if related package is installed.