Move is_weight_compression_needed function to common
#3669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aobolensk
force-pushed
the
3668
branch
2 times, most recently
from
48cd605 to
d1a1ca6
Compare
aobolensk
force-pushed
the
3668
branch
2 times, most recently
from
a390263 to
04cf656
Compare
aobolensk
force-pushed
the
3668
branch
4 times, most recently
from
bea908d to
bc9ddb8
Compare
daniil-lyakhov
requested changes
Oct 1, 2025
Comment on lines
292
to
294
| def is_weight_compression_needed(self) -> bool: | ||
| """ | ||
| Determine whether weight compression is needed based on advanced quantization parameters. |
There was a problem hiding this comment.
Please move the function to the module scope, currently it is a method of advanced parameters
Comment on lines
259
to
261
| :param COMPRESS_WEIGHTS: A key in the `backend_params` dictionary that indicates whether | ||
| weight compression should be applied. If set to False, weight compression is disabled. | ||
| By default, weight compression is enabled (True). |
There was a problem hiding this comment.
Suggested change
| :param COMPRESS_WEIGHTS: A key in the `backend_params` dictionary that indicates whether | |
| weight compression should be applied. If set to False, weight compression is disabled. | |
| By default, weight compression is enabled (True). | |
| :param compress_weights: Indicates whether | |
| weight compression should be applied. If set to False, weight compression is disabled. | |
| By default, weight compression is enabled (True). |
| :param COMPRESS_WEIGHTS: A key in the `backend_params` dictionary that indicates whether | ||
| weight compression should be applied. If set to False, weight compression is disabled. | ||
| By default, weight compression is enabled (True). | ||
| :type COMPRESS_WEIGHTS: str |
There was a problem hiding this comment.
Suggested change
| :type COMPRESS_WEIGHTS: str | |
| :type compress_weights: bool |
| backend_params: dict[str, Any] = field(default_factory=dict) | ||
|
|
||
| # Backend parameter names | ||
| COMPRESS_WEIGHTS = "compress_weights" |
There was a problem hiding this comment.
Suggested change
| COMPRESS_WEIGHTS = "compress_weights" | |
| compress_weights = True |
Please move this line to the line 272
aobolensk
force-pushed
the
3668
branch
2 times, most recently
from
08edc7f to
ca0d665
Compare
|
Should be merged after #3662 |
Rebased the changes after merging this PR and applied similar changes for ONNX as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
backend_parameters.pyfiles and move it from Torch FX and OpenVINO backends to the commonadvanced_parameters.pyRelated tickets
Closes Issue #3668