Fixing outline view of compact source files #466
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shivam71
commented
Sep 18, 2025
shivam71
commented
- Compact source files in java don't have top level class.
- Methods and fields are allowed as top level elements .
- Due to the erroneous computation of the end position for the hidden final class created to scaffold the compact source file methods and fields the outline view was not showing the document symbols for these files.
- This patch does a simple fix to ensure that the LSP backend sends ranges where end position for a document symbol if not found is taken same as the start position .
- Final fix could perhaps correct the end position computation directly .
oracle-contributor-agreement
bot
added
the
OCA Verified
shivam71
force-pushed
the
compact_src_file_outline_fix
branch
from
cec1a0c to
2ba521c
Compare
|
Netbeans PR #8856 |
nit: would you please rename the patch file to |
sid-srini
changed the title
shivam71
force-pushed
the
compact_src_file_outline_fix
branch
from
2ba521c to
d2b29d2
Compare
shivam71
force-pushed
the
compact_src_file_outline_fix
branch
from
d2b29d2 to
191ae63
Compare
sid-srini
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.