-
Notifications
You must be signed in to change notification settings - Fork 22
feat(curations): Add a VCS curation for NPM::three #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
three.js releases are tagged like this: `r<feature release>`, e.g. instead of 0.178.0 the tag says r178 and is not found by ort. Signed-off-by: cz-dev-ge <[email protected]>
This is the log:
|
Ok, this indeed does not even have a |
vcs: | ||
type: "Git" | ||
url: "https://github.com/mrdoob/three.js.git" | ||
revision: "3b1ff7661884f26e6d9af1d94c293129aaba885c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've verified this to match https://github.com/mrdoob/three.js/releases/tag/r178.
type: "Git" | ||
url: "https://github.com/mrdoob/three.js.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these two lines can be omitted, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes.
three.js releases are tagged like this:
r<feature release>
, e.g. instead of 0.178.0 the tag says r178 and is not found by ort.