Skip to content

fix(askalono): Crawl in all files instead of just license-like ones #10380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Draft

fix(askalono): Crawl in all files instead of just license-like ones #10380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/scanners/askalono/src/main/kotlin/Askalono.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class Askalono(
override fun runScanner(path: File, context: ScanContext): String {
val process = AskalonoCommand.run(
"--format", "json",
"crawl", path.absolutePath
"crawl", "--glob", "*", path.absolutePath
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be changed to take the arguments from the configuration property, then it would work correctly with the scan result storage (just adding the option here will not trigger a rescan).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wouldn't it be confusing to have a glob option for this scanner, but not for others?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you mean the whole command line, like for ScanCode, I guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I meant. Not making it configurable, but just making it visible to the matcher for the scan storage.

)

return with(process) {
Expand Down
Loading