Skip to content

fix(conan): Properly check for Conan version #10493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(conan): Properly check for Conan version #10493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/package-managers/conan/src/main/kotlin/Conan.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class Conan(
override val globsForDefinitionFiles = listOf("conanfile*.txt", "conanfile*.py")

private val handler by lazy {
if (command.getVersion().startsWith("1.")) {
if (command.getVersion().startsWith("Conan version 1.")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this prefix is already done in line 77, so I don't think it's necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed that one.
Then I am running out of ideas. I am still running into the issue that ConanV2Handler is used in combination with Conan version 1:

14:12:24.377 [DefaultDispatcher-worker-1] WARN  org.ossreviewtoolkit.plugins.packagemanagers.conan.ConanV2Handler - Failed to list remotes.
14:12:25.568 [DefaultDispatcher-worker-1] ERROR org.ossreviewtoolkit.analyzer.PackageManager - Conan failed to resolve dependencies for path 'conanfile.py': IOException: Running 'conan graph info -f json --out-file /tmp/ort-ConanV2Handler12215941369031907775/info.json -s compiler=gcc -s compiler.libcxx=libstdc++ -s compiler.version=11.1 conanfile.py' in '/builds/Jens.Erdmann/mflstd-impl' failed with exit code 1:
ERROR: Unknown command 'graph'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @nnobelis can help here. But please move the discussion to, well, GitHub discussions or to Slack then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, #10127 might be of interest to you, @jens-erdmann.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Sorry for the noise

ConanV1Handler(this)
} else {
ConanV2Handler(this)
Expand Down
Loading