Skip to content

Conversation

Prakash-Mishra-9ghz
Copy link

I have added the Nomos binary from FOSSology to the ORT Docker build.
This will allow the new FOSSology-nomos scanner to be used directly inside the Docker image without extra setup.

I am opening this as a draft because the scanner integration itself is still under review in #10631
Once that is merged, this Docker change will make the scanner usable out of the box.

@sschuberth
Copy link
Member

I am opening this as a draft because the scanner integration itself is still under review in #10631
Once that is merged, this Docker change will make the scanner usable out of the box.

Actually, I believe this should be done the opposite way: This commit should be added as the first commit to PR #10631 as it provides the prerequisite for running Nomos by adding it to the Docker image. Based on that, the actual scanner implementation should make use of the scanner, and also add a functional test as part of the implementation.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.39%. Comparing base (65584ec) to head (fbd1689).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10764      +/-   ##
============================================
+ Coverage     57.34%   57.39%   +0.04%     
- Complexity     1668     1677       +9     
============================================
  Files           344      346       +2     
  Lines         12747    12764      +17     
  Branches       1209     1209              
============================================
+ Hits           7310     7326      +16     
- Misses         4972     4973       +1     
  Partials        465      465              
Flag Coverage Δ
funTest-non-docker 33.01% <ø> (+0.14%) ⬆️
test-ubuntu-24.04 41.90% <ø> (ø)
test-windows-2025 41.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Prakash-Mishra-9ghz
Copy link
Author

Closing this PR as per @sschuberth’s feedback.
The Docker changes will be included directly in PR #10631 together with the Nomos scanner implementation and functional test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants