Skip to content

chore(CODEOWNERS): Use usernames instead of groups #10818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(CODEOWNERS): Use usernames instead of groups #10818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,17 @@
# last matching pattern is used, see
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners#codeowners-syntax

* @oss-review-toolkit/kotlin-devs
*.md @oss-review-toolkit/core-devs
/**/*Sw360* @oss-review-toolkit/kotlin-devs @bs-ondem @oheger-bosch
/advisor/ @oss-review-toolkit/kotlin-devs @MarcelBochtler @oheger-bosch
/clients/fossid-webapp/ @oss-review-toolkit/kotlin-devs @nnobelis
# Members of @oss-review-toolkit/kotlin-devs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not quote any https://github.com/orgs/oss-review-toolkit/teams names here as I wanted to go through these with @oss-review-toolkit/tsc soon to clean up some redundancy and confusion there.

But we should probably document the general idea behind this "catch all" entry, like by saying "General owners of the Kotlin code base."

Copy link
Member Author

@mnonnenmacher mnonnenmacher Sep 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about first discussing how we want to organize this and then updating the descriptions in the file afterward, and keep the group based assignments until then? AFAIK we also have no public list of people who are committers (according to the role described in the charter) and if the "owners of legally relevant documents" proposed below are not equal to the TSC members this also needs to be documented somewhere.

Copy link
Member

@sschuberth sschuberth Sep 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course I'm fine with discussing the GitHub team structure first. But even after that I'd not quote the (new) names here, just because it creates maintenance effort if teams change again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point is that I want to describe why people are listed here, not explain what the file patterns mean. Currently this mostly maps to people who are in certain teams which also give them write permission to the repository. In future I would prefer something like "TSC members" or "Project committers" and also add links to the official lists of people with these roles so that it is clear how the lists are updated. For example, "Owners of legally relevant documents" does not explain why these users own these documents. That's why I wanted to keep the descriptions technical for now.

* @fviernau @MarcelBochtler @mnonnenmacher @nnobelis @oheger-bosch @sschuberth

# Members of @oss-review-toolkit/core-devs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, I'd prefer to more general comment to describe the idea, like "Contributors who usually review documentation."

*.md @fviernau @MarcelBochtler @mnonnenmacher @sschuberth @tsteenbe

# Owners of the web app reporter.
/plugins/reporters/web-app-template/ @tsteenbe
/spdx-utils/src/main/ @oss-review-toolkit/core-devs
/LICENSE @oss-review-toolkit/core-devs

# Members of @oss-review-toolkit/core-devs.
/spdx-utils/src/main/ @fviernau @MarcelBochtler @mnonnenmacher @sschuberth @tsteenbe

# Members of @oss-review-toolkit/core-devs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment could be "Owners of legally relevant documents."

/LICENSE @fviernau @MarcelBochtler @mnonnenmacher @sschuberth @tsteenbe
Loading