Skip to content

Update README.md so docker run downloads from ghcr #9881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md so docker run downloads from ghcr #9881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Depending on how ORT was installed, it can be run in the following ways:
* If the Docker image was built, use

```shell
docker run ort --help
docker run ghcr.io/oss-review-toolkit/ort --help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 109 there are the build instructions which use ort as the image tag, which was used by the previous version of the command. Do we need any alignment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the list item title in line 124 says "If the Docker image was built" (i.e. it was built locally by the user), so I believe the change to be invalid and be caused by a misunderstanding that these are not usage instructions for the case when a published image is downloaded from the Docker registry.

What do you think, @mnonnenmacher, as you where mentioning this stale PR in today's meeting?

```

You can find further hints for using ORT with Docker in the [documentation](./website/docs/guides/docker.md).
Expand Down
Loading