Skip to content

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 6, 2025

For some reason these structs and enums were never used. Should I delete them instead, or is there a plan to use them for something?

  • SignalAttributeValue
  • AttributeValueType - also renamed values
  • AttrDefault

* `SignalAttributeValue`
* `AttributeValueType` - also renamed values
* `AttrDefault`
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR comments out three unused data structures in the main library file to clean up the codebase. The maintainer is questioning whether these should be deleted entirely or kept for future use.

  • Comments out unused enum and struct definitions with FIXME notes
  • Renames enum variant names for consistency during the commenting process
  • Adds explanatory comments about the unused status

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-authored-by: Copilot <[email protected]>
@tegimeki
Copy link
Member

It might be better to get #22 up to date once the other PRs land; it adds some of the unused features commented-out here and could be built upon for remaining items such as BA_DEF_DEF_REL_ etc.

@nyurik
Copy link
Member Author

nyurik commented Oct 18, 2025

It might be better to get #22 up to date once the other PRs land; it adds some of the unused features commented-out here and could be built upon for remaining items such as BA_DEF_DEF_REL_ etc.

Agree, it might be a better overall approach, esp when we switch to the new pest lexer from https://github.com/oxibus/can-dbc-pest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants