Skip to content

fix: correctly feature gate default features #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
Merged

fix: correctly feature gate default features #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4037d2
fix: correctly feature gate default features
Nemo157 Oct 21, 2025
11a226e
Merge branch 'main' into push-vtqlnrvlyrku
nyurik Oct 23, 2025
b4e9ba1
cleanup features a bit
nyurik Oct 23, 2025
e57771b
verify that no-default check compiles
nyurik Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,13 @@ categories = ["embedded", "no-std", "encoding", "parsing"]
edition = "2021"
rust-version = "1.74"

[[example]]
name = "file_parser"
path = "examples/file_parser.rs"
required-features = ["encodings"]

[features]
default = ["with-serde", "encodings"]
default = ["serde", "encodings"]
# Support decoding from all standard encodings, e.g. cp1251 commonly used for dbc
encodings = ["dep:encoding_rs"]
serde = ["dep:serde"]
Expand Down
3 changes: 2 additions & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ build-diagram:
# Quick compile without building a binary
check:
cargo check {{packages}} {{features}} {{targets}}
cargo check {{packages}} --no-default-features {{targets}}

# Generate code coverage report to upload to codecov.io
ci-coverage: env-info && \
Expand All @@ -43,7 +44,7 @@ ci-coverage: env-info && \
mkdir -p target/llvm-cov

# Run all tests as expected by CI
ci-test: env-info test-fmt clippy test test-doc deny && assert-git-is-clean
ci-test: env-info test-fmt check clippy test test-doc deny && assert-git-is-clean

# Run minimal subset of tests to ensure compatibility with MSRV
ci-test-msrv: env-info check test
Expand Down
Loading