Skip to content

Typescript wrap touchups #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: origin-dev
Choose a base branch
from
Open

Typescript wrap touchups #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd9b3b
Updated template for TS Wrap
namesty Sep 13, 2023
cd835cc
Bumped javascript-vm-js version to use latest pwr
namesty Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli/src/lib/defaults/build-strategies/wasm/javascript/image/Dockerfile.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ RUN apt-get update && apt-get install -y curl git

# Download and install pwrup
RUN curl -L https://raw.githubusercontent.com/polywrap/pwr/main/pwrup/install | bash
# Source bash and use pwrup to install pwr
RUN /bin/bash -i -c "source ~/.bashrc; pwrup"
# Use pwrup to install pwr
RUN /root/.pwr/bin/pwrup

WORKDIR /project
# Copy the script file to build
COPY {{#polywrap_module}}{{moduleFilePath}}{{/polywrap_module}} ./wrap.js
# Use pwr to build the script
RUN /bin/bash -i -c "pwr js build -f ./wrap.js -o build"
RUN /root/.pwr/bin/pwr js build -f ./wrap.js
2 changes: 1 addition & 1 deletion packages/cli/src/lib/defaults/build-strategies/wasm/javascript/vm/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.0
0.1.1
Copy link
Contributor

@dOrgJelli dOrgJelli Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to release this, you need to add | /workflows/cd-containers to your PR's title: https://github.com/polywrap/cli/blob/origin-dev/.github/workflows/cd-containers.yaml#L12

Also, be sure to update the VM image version within the strategy: https://github.com/polywrap/cli/blob/fe8b36f676e11aaac958a75475b05961681700a7/packages/cli/src/lib/build-strategies/strategies/DockerVMStrategy.ts#L53

3 changes: 0 additions & 3 deletions packages/templates/wasm/typescript/polywrap.build.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/templates/wasm/typescript/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import typescript from "@rollup/plugin-typescript";
import resolve from "@rollup/plugin-node-resolve";
import commonjs from "@rollup/plugin-commonjs";
import terser from "@rollup/plugin-terser";
import shims from "./shims.js";
import shims from "./shims/shims.js";

export default {
input: "src/wrap/entry.ts",
Expand Down
Loading