Add plimit and increase cache size #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ivankalinovski
commented
Feb 2, 2025
ivankalinovski
commented
- Add plimit to protect from spikes
- Incease cache size to better performance in spikes.
added 2 commits
February 2, 2025 11:11
- Add plimit to protect from spikes - Incease cache size to better performance in spikes.
Add to node-options experimental-vm-modules to support plimit on jest
|
|
||
| const initPLimit = async () => { | ||
| if (!pLimit) { | ||
| const module = await import('p-limit') |
Collaborator
There was a problem hiding this comment.
this assumes ESM, is it working? don't we use CJS?
| const execAsync = async (object, filter, {enableEnv = false, throwOnError = false} = {}) => { | ||
| try { | ||
| const data = await nativeJq.execAsync(JSON.stringify(object), formatFilter(filter, {enableEnv})) | ||
| const limit = await initPLimit() |
Collaborator
There was a problem hiding this comment.
- what do you think about passing the plimit object from outside and then the service can create the p-limit optimized to its needs.
For example:
import pLimit from 'p-limi'
const limit = pLimit()
execAsync(object, filter, {pLimit})- Don't we need to initialize the pLimit earlier?
| const module = await import('p-limit') | ||
| pLimit = module.default(currentLimit) | ||
| } | ||
| return pLimit |
Collaborator
There was a problem hiding this comment.
Should it be like this so we won't initialize the pLimit object on every request?
Suggested change
| return pLimit | |
| return pLimit(currentLimit) |
| "install": "node-gyp rebuild", | ||
| "prepack": "npm run test", | ||
| "test": "jest" | ||
| "test": "NODE_OPTIONS='--experimental-vm-modules' jest" |
Collaborator
There was a problem hiding this comment.
We are mixing cjs and esm, better to stick with one until we do the change to esm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.