Ignore local version identifiers in constraints. #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senokay
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
senokay
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
Torch is frequently installed with a local version identifier (e.g. `+cu126`), but that identifier causes an issue with pip because there is no public package with that identifier unless an explicit alternative index is used. Stripping the local version identifier should be safe, as we are only using constraints to ensure that per-model dependencies are aligned with existing installations.
senokay
force-pushed
the
ignore-local-version-in-constraints
branch
from
0a2f22d to
c819823
Compare
senokay
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
senokay
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
senokay
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This is a bit weird because we test on pytorch nightly, where the version is like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch is frequently installed with a local version identifier (e.g.
+cu126), but that identifier causes an issue with pip because there is no public package with that identifier unless an explicit alternative index is used. The issue also happens to come with a quite cryptic ResolutionImpossible error (pypa/pip#13422) which completely obscures the actual issue.Stripping the local version identifier should be safe, as we are only using constraints to ensure that per-model dependencies are aligned with existing installations.
Fun anecdote: Gemini was extensively used to discover the underlying issue. Full transcript here.