refactor: replace context.WithCancel with t.Context #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Looks like the CI failed here @hongmengning |
Signed-off-by: hongmengning <[email protected]>
Author
@crozzy Sorry for handling this so late. The error was due to unused packages not being removed. I have modified it, and it can now compile successfully. Please review it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize code using a more modern writing style. Official support from Go Team. https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.